feat: unique getBuildPath invoke and ignore .git branch name contain … #33233

SallyHuo-TAOS · 2025-10-13T10:21:51Z

…binary name

Description

Please briefly describe the code changes in this pull request.

Checklist

Please check the items in the checklist if applicable.

Is the user manual updated?
Are the test cases passed and automated?
Is there no significant decrease in test coverage?

…binary name

gemini-code-assist · 2025-10-13T10:23:00Z

Summary of Changes

Hello @SallyHuo-TAOS, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refactoring the test framework's utility functions to enhance modularity and efficiency. It centralizes the logic for locating build paths into a shared utility module and introduces a mechanism to skip version control directories during path searches. These changes aim to make the test suite more robust and easier to manage.

Highlights

Centralized Build Path Retrieval: The getBuildPath function, previously duplicated across numerous test files, has been removed from individual test classes and replaced with a centralized call to tdCom.getBuildPath(). This consolidates common utility logic, improving code maintainability and reducing redundancy.
Improved Path Traversal Logic: The utility functions responsible for finding build paths (getPath, getBuildPath, getTaosdemoPath, getTDenginePath) have been enhanced to explicitly ignore .git directories during their file system traversal. This prevents unnecessary processing and potential issues related to version control metadata.
Streamlined Test Imports: Several test files have updated their import statements to directly import tdCom from new_test_framework.utils, reflecting the new centralized utility structure.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request is a great refactoring effort to centralize the getBuildPath logic into tdCom.getBuildPath(), removing a lot of duplicated code across the test suite. This significantly improves maintainability. The change to ignore .git directories during path searches is also a good improvement.

I've found one critical issue where an incomplete refactoring introduces a syntax error, and one minor issue with a duplicated import. Please see the detailed comments.

test/cases/41-StreamProcessing/23-Compatibility/test_compatibility_cross_version.py

test/cases/41-StreamProcessing/30-OldPyCases/test_oldcase_taosdShell.py

…binary name

Refactor test_subscribeDb0.py to improve readability and maintainability.

Copilot

Pull Request Overview

This PR optimizes path-finding functions and removes duplicate code across the test framework. The changes consolidate duplicated getBuildPath implementations by replacing them with calls to a shared tdCom.getBuildPath() utility function, and add .git directory filtering to prevent unnecessary directory traversal during build path searches.

Removes duplicate getBuildPath method implementations across 50+ test files
Adds .git directory filtering to improve search efficiency in path-finding utilities
Consolidates path-finding logic by using shared tdCom.getBuildPath() function

Reviewed Changes

Copilot reviewed 75 out of 75 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
test/new_test_framework/utils/pathFinding.py	Added `.git` directory exclusion to `getTaosdemoPath` and `getTDenginePath` methods
test/new_test_framework/utils/common.py	Added `.git` directory exclusion to `getBuildPath` method
test/new_test_framework/utils/before_test.py	Added `.git` directory exclusion to `getPath` method
test/cases/uncatalog/system-test/99-TDcase/*.py	Removed duplicate `getBuildPath` methods and updated imports to use `tdCom`
test/cases/uncatalog/system-test/7-tmq/*.py	Removed duplicate `getBuildPath` methods and replaced calls with `tdCom.getBuildPath()`
test/cases/uncatalog/system-test/6-cluster/*.py	Removed duplicate `getBuildPath` methods from cluster test files
test/cases/uncatalog/system-test/2-query/*.py	Updated query test files to use `tdCom.getBuildPath()`
test/cases/uncatalog/system-test/0-others/*.py	Consolidated path-finding logic in miscellaneous test files
test/cases/70-Node/05-Cluster/*.py	Removed duplicate implementations from cluster node tests
test/cases/41-StreamProcessing/*.py	Updated stream processing tests to use shared utility
test/cases/10-DataIngestion/*.py	Consolidated path-finding in data ingestion tests
test/cases/04-SuperTables/*.py	Updated super table tests to use shared utility

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-14T02:25:54Z

test/cases/uncatalog/system-test/7-tmq/test_subscribeStb3.py

+

Unnecessary blank line added at the end of the file. Consider removing this trailing whitespace.

Suggested change

Copilot · 2025-10-14T02:25:54Z

test/cases/uncatalog/system-test/7-tmq/test_subscribeDb0.py

        tdLog.success(f"{__file__} successfully executed")

 event = threading.Event()
+


Unnecessary blank line added at the end of the file. Consider removing this trailing whitespace.

Suggested change

feici02

LGTM

feat: unique getBuildPath invoke and ignore .git branch name contain …

62222bb

…binary name

SallyHuo-TAOS requested a review from a team as a code owner October 13, 2025 10:21

taosdata-bot bot added the team platform label Oct 13, 2025

gemini-code-assist bot reviewed Oct 13, 2025

View reviewed changes

test/cases/41-StreamProcessing/23-Compatibility/test_compatibility_cross_version.py Outdated Show resolved Hide resolved

test/cases/41-StreamProcessing/30-OldPyCases/test_oldcase_taosdShell.py Show resolved Hide resolved

SallyHuo-TAOS added 5 commits October 13, 2025 18:34

feat: unique getBuildPath invoke and ignore .git branch name contain …

f505eab

…binary name

Update test_oldcase_taosdShell.py

4f4f946

Update test_subscribeStb3.py

f00e71c

Refactor test_subscribeDb0.py for clarity

8cdcb62

Refactor test_subscribeDb0.py to improve readability and maintainability.

Update test_compatibility_cross_version.py

cb0e21b

tomchon requested a review from Copilot October 14, 2025 02:25

Copilot AI reviewed Oct 14, 2025

View reviewed changes

feici02 approved these changes Oct 14, 2025

View reviewed changes

feici02 merged commit 98b6d11 into main Oct 14, 2025
5 of 6 checks passed

feici02 deleted the feat/huoh/TD-33281 branch October 14, 2025 07:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: unique getBuildPath invoke and ignore .git branch name contain … #33233

feat: unique getBuildPath invoke and ignore .git branch name contain … #33233

Uh oh!

SallyHuo-TAOS commented Oct 13, 2025

Uh oh!

gemini-code-assist bot commented Oct 13, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 14, 2025

Uh oh!

Copilot AI Oct 14, 2025

Uh oh!

feici02 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		tdLog.success(f"{__file__} successfully executed")

		event = threading.Event()

feat: unique getBuildPath invoke and ignore .git branch name contain … #33233

feat: unique getBuildPath invoke and ignore .git branch name contain … #33233

Uh oh!

Conversation

SallyHuo-TAOS commented Oct 13, 2025

Description

Checklist

Uh oh!

gemini-code-assist bot commented Oct 13, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

feici02 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants