merge: from 3.3.6 to main branch

[guanshengliang]

Description

Please briefly describe the code changes in this pull request.

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @guanshengliang, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the stability, observability, and maintainability of the system. It introduces more explicit error handling in client-side C examples, improves the robustness of dnode-mnode communication by handling RPC timeouts, and provides clearer error diagnostics during mnode startup. Additionally, it refines the monitoring framework's gauge registration process for better code quality.

Highlights

• Improved Error Handling in C Example: Added comprehensive error checking for taos_connect and taos_options_connection calls in the C connection example, ensuring more robust client-side operations.
• Enhanced Dnode RPC Communication: Implemented logic to rotate the mnode endpoint set if an RPC timeout occurs during status requests, improving resilience in dnode management. Also, enhanced trace logging for status requests.
• Refined Mnode Initialization Error Messages: Updated error messages within the mndOpen function to include specific step numbers, making it easier to pinpoint the exact stage of failure during mnode initialization.
• Dynamic Gauge Registration in Monitoring: Modified the monitoring framework to dynamically calculate the size of the dnodes_gauges array for registration, preventing hardcoded limits and improving maintainability.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request merges changes from the 3.3.6 release branch into main. The changes primarily focus on improving error handling, logging, and maintainability in several C source files. For instance, error messages in mndMain.c are now more descriptive, and a magic number in monFramework.c has been replaced for better code clarity. While most changes are beneficial, I've identified a potential issue in dmHandle.c where an incorrect error code might be logged in a timeout scenario, which could hinder debugging efforts. My feedback includes a suggestion to correct this.

[gemini-code-assist]

In the case of a timeout error (code == TSDB_CODE_TIMEOUT_ERROR), the rpcRsp structure may not be populated, and rpcRsp.code could contain an uninitialized or incorrect value. Using tstrerror(rpcRsp.code) in the dInfo log message might lead to misleading or incorrect error logging. It would be safer and more accurate to use tstrerror(code) here, which reflects the actual timeout error that occurred. This would be consistent with the dError log message on line 278.

      dInfo("Rotate mnode ep set since failed to SendRecv status req %s, epSet:%s, inUse:%d", tstrerror(code),
            tbuf, epSet.inUse);