Fix/test case/err desc main

[facetosea]

Description

Please briefly describe the code changes in this pull request.

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @facetosea, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the error handling within a specific stream processing test case. The primary goal is to make the test more resilient to variations in error messages and to provide clearer, more informative logs when stream creation fails due to incorrect usage of window query parameters. By refining the error detection logic and improving logging, the PR contributes to more robust and maintainable test infrastructure.

Highlights

• Refined Error Message Check: The condition for identifying a specific stream processing error related to window query functions (_WSTART, _WEND, _WDURATION) has been made more robust by checking for keywords separately, allowing for greater flexibility in matching error messages.
• Improved Error Logging: The error logging for stream creation failures now includes the actual exception message, providing more detailed and useful information for debugging.
• Simplified Exception Re-raising: The mechanism for re-raising unexpected exceptions has been simplified, directly re-raising the caught exception without wrapping it in a new generic Exception.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request improves exception handling in a test case. The changes are good, especially the use of raise to re-raise exceptions, which is a best practice. However, I've identified a potential bug in the test logic where a successful execution (when a failure is expected) would not fail the test. I've also suggested making the error message check case-insensitive for better robustness.

[gemini-code-assist]

While the changes are an improvement, the test logic is still incomplete. It doesn't handle the case where tdSql.execute succeeds without raising an exception. In this scenario, the test should fail, but it will currently pass silently. An explicit assertion should be added to ensure an exception is raised.

Additionally, to make the error message check more robust, it's a good practice to make it case-insensitive.

Suggested change

	try:
	tdSql.execute(stream1,queryTimes=2)
	except Exception as e:
	if "_WSTART, _WEND and _WDURATION can only be used in window query" in str(e):
	tdLog.info(f"create stream error :_WSTART, _WEND and _WDURATION can only be used in window query")
	if "_WSTART, _WEND" in str(e) and "can only be used in window query" in str(e):
	tdLog.info(f"create stream error: {e}")
	else:
	raise Exception(f"error: _WSTART, _WEND and _WDURATION must be used in window query")
	raise
	try:
	tdSql.execute(stream1,queryTimes=2)
	raise AssertionError("Exception was expected when creating stream, but it was not raised.")
	except Exception as e:
	err_msg = str(e).lower()
	if "_wstart, _wend" in err_msg and "can only be used in window query" in err_msg:
	tdLog.info(f"create stream error: {e}")
	else:
	raise

[CLAassistant]

All committers have signed the CLA.