Fix/fixMemleak336

[yihaoDeng]

Description

Please briefly describe the code changes in this pull request.

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @yihaoDeng, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a memory leak, identified as '336', by implementing more rigorous resource management within the transport layer. The changes focus on ensuring proper cleanup of client request contexts and preventing dangling pointers after context merging, thereby improving the overall stability and memory efficiency of the system.

Highlights

• Memory Leak Fix in Client Request Handling: Introduced a new helper function, freeUserCtx, in transCli.c to ensure that the userCtx associated with client requests (SCliReq) is consistently cleaned up. This function is now called in notifyExceptCb on both successful completion and error paths, preventing potential memory leaks.
• Improved Memory Management in Context Merging: Enhanced the transCtxMerge function in transComm.c by explicitly nullifying src->args and src->brokenVal.val after taosHashCleanup. This prevents dangling pointers and potential double-free issues, contributing to more robust memory management.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request appears to fix a memory leak by ensuring userCtx is cleaned up in notifyExceptCb and by nullifying pointers in transCtxMerge after cleanup to prevent dangling pointers. The changes are generally good. I've suggested a small refactoring in transCli.c to reduce code duplication and improve readability.

[gemini-code-assist]

The calls to freeUserCtx(pReq) and destroyReq(pReq) are duplicated in both the success and error paths. You can refactor this to remove the duplication, which will make the code cleaner and easier to maintain.

  if (code == 0) {
    pInst->cfp(pInst->parent, pResp, NULL);
  }

  freeUserCtx(pReq);
  destroyReq(pReq);
  return code;

[codecov]

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (3.3.6@648a6d4). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
source/libs/transport/src/transCli.c	40.00%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             3.3.6   #33261   +/-   ##
========================================
  Coverage         ?   57.01%           
========================================
  Files            ?      431           
  Lines            ?   261376           
  Branches         ?    92102           
========================================
  Hits             ?   149026           
  Misses           ?    61002           
  Partials         ?    51348           

Flag	Coverage Δ
TDengine	57.01% <57.14%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}