merge: from 3.3.6 to main branch

[guanshengliang]

Description

Please briefly describe the code changes in this pull request.

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @guanshengliang, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates two targeted improvements from the 3.3.6 branch into the main branch. It expands the configurable range for a specific RPC logging threshold and refines error reporting during worker thread initialization, aiming to improve system flexibility and diagnostic capabilities.

Highlights

• Configuration Update: The maximum allowed value for the rpcRecvLogThreshold configuration parameter has been significantly increased from 1024 to 1024*1024.
• Error Handling Improvement: Error logging for thread creation failures in tworker.c has been enhanced to provide a more descriptive message instead of just setting an error code.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request appears to be a merge from a release branch. The changes include increasing the maximum value for the rpcRecvLogThreshold configuration and fixing an error handling issue in thread creation. My review focuses on the configuration change, where the new maximum value seems unusually large and might be a typo. I've also pointed out a minor style inconsistency.

[gemini-code-assist]

The maximum value for rpcRecvLogThreshold has been increased from 1024 to 1024*1024 (1,048,576). According to the comment for tsRpcRecvLogThreshold on line 406, the unit is seconds. This new maximum value is approximately 12 days, which seems excessively high for an RPC receive log threshold. Could you please confirm if this value is correct and not a typo? If the unit is intended to be milliseconds, the variable name and associated comments should be updated for clarity.

Additionally, for consistency with other parts of the file (e.g., lines 970-971), please add spaces around the multiplication operator: 1024 * 1024.

  TAOS_CHECK_RETURN(cfgAddInt32(pCfg, "rpcRecvLogThreshold", tsRpcRecvLogThreshold, 1, 1024 * 1024, CFG_SCOPE_SERVER, CFG_DYN_SERVER,CFG_CATEGORY_LOCAL));

[gemini-code-assist]

The previous implementation incorrectly overwrote terrno with TSDB_CODE_OUT_OF_MEMORY, masking the actual error from taosThreadCreate. This change correctly logs the error from terrno, which is a significant improvement in error handling. However, taosThreadCreate might fail for reasons other than out of memory, and the old code would not have captured that. It is good that you are now logging the actual error.