Skip to content

Conversation

@tomchon
Copy link
Contributor

@tomchon tomchon commented Oct 21, 2025

enh:remove obsolete test case files for long-running and TD-GPT tests from the parallel_test directory

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @tomchon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the test infrastructure by removing several obsolete test case definition files. The aim is to streamline the testing process, reduce maintenance overhead, and ensure that the test suite accurately reflects the current state and requirements of the project by eliminating outdated configurations for coverage, parallel, long-running, and TD-GPT tests.

Highlights

  • Test File Removal: Removed the tests/coverage/covtests.task file, which contained a comprehensive list of pytest commands for various test categories including DataTypes, Databases, Tables, SuperTables, DataIngestion, DataQuerying, Functions, TimeSeriesExtensions, DataSubscription, ManageNodes, Metadata, Show, Users, UDFs, JoinQueries, DataCompression, and Views.
  • Parallel Test Cleanup: Eliminated tests/parallel_test/cases.task, which defined unit tests and documentation examples tests for multiple languages (C, Python, Node, C#, JDBC, Rust, Go, R).
  • Long-Running Test Removal: Deleted tests/parallel_test/longtimeruning_cases.task, previously used for configuring long-running system tests and tsim tests.
  • TD-GPT Test Removal: Removed tests/parallel_test/tdgpt_cases.task, which contained definitions for TD-GPT related test cases.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes several test case files that are considered obsolete. The cleanup is generally a good improvement. However, I've identified a potential issue where the deletion of tests/parallel_test/cases.task will break the tests/parallel_test/split_case.sh script due to a hardcoded dependency. This could impact CI/CD pipelines, particularly for Windows environments. I've also noted a typo in one of the deleted filenames, which warrants a quick verification. Please see the detailed comments.

@guanshengliang guanshengliang merged commit 76bc8c1 into main Oct 21, 2025
4 of 6 checks passed
@guanshengliang guanshengliang deleted the enh/main-delete-casetask-file branch October 21, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants