fix explore-sys metric's sub table name

[sheyanjie-qq]

Description

Please briefly describe the code changes in this pull request.

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @sheyanjie-qq, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue with the naming of sub-tables for explorer_sys metrics. It implements new logic to ensure that these metrics are assigned appropriate sub-table names based on their endpoint tag, thereby improving data organization and consistency. The change includes corresponding unit tests to verify the correctness of the new naming convention.

Highlights

• Metric Sub-Table Naming Logic: Introduced specific logic within the get_sub_table_name function to correctly generate sub-table names for explorer_sys metrics, utilizing the endpoint tag.
• Test Coverage: Added new unit tests for the get_sub_table_name function to validate the new explorer_sys metric naming convention and ensure proper handling of related cases.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds special handling for explorer_sys metrics to generate a sub-table name. While the intent is correct and supported by a good test case, the implementation has a flaw: it fails to sanitize the endpoint value used in the table name. This will result in invalid table names containing characters like . and :, leading to SQL errors. I've provided a review comment with a code suggestion that not only fixes this bug by using util.ToValidTableName but also simplifies the newly added logic for better maintainability.