-
Notifications
You must be signed in to change notification settings - Fork 5k
docs: update release note for 3.3.8.4 in office web #33456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @feici02, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is dedicated to the release preparation for version 3.3.8.4. It involves updating the project's internal version identifier and integrating detailed release notes that outline the latest features, performance improvements, and resolved issues. Additionally, it ensures that all user-facing documentation, including installation instructions and tool references, is synchronized with the new version, providing accurate and up-to-date information for users. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the version to 3.3.8.4 across various documentation files and adds the corresponding release notes in both English and Chinese. The changes are mostly correct, but I've found a few typos and inconsistencies in the new release note files. Please see my detailed comments for suggestions.
| 14. enh: OpenTSDB data-in support timestamp/value field rename | ||
| 15. enh: unify login-register process in enterprise & community | ||
| 16. enh: add configuration parameter rpcRecvLogThreshold to set the threshold for warning logs in the rpc module | ||
| 17. en: Explorer Dashboard node table now is sortable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 10. fix: state window fails to properly handle data with NULL states | ||
| 11. fix: crash when concurrent writes and last queries are performed simultaneously. | ||
| 12. fix: new values cannot be immediately queried after updating server configuration parameters | ||
| 13. fix: fix C WebSocket stmt2 automatic reconnection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 18. fix: crash caused by memory cleanup when sync message sending fails | ||
| 19. fix: incorrect _wduration result in time window queries with sliding. | ||
| 20. fix: invalid sttblockreader initialization actions in window queries. | ||
| 21. fix: resolved incorrect end_point information in perf_connections |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The term 'end_point' is used here, but 'endpoint' is used elsewhere in this file (e.g., line 9) and is more common. For consistency, it's better to use 'endpoint'.
| 21. fix: resolved incorrect end_point information in perf_connections | |
| 21. fix: resolved incorrect endpoint information in perf_connections |
| 10. 修复:状态窗口未能正确处理 NULL 值数据 | ||
| 11. 修复:并发写入与 last 查询同时进行时,出现极小概率崩溃的问题。 | ||
| 12. 修复:更新服务端配置参数后无法立即查询到新参数值的问题。 | ||
| 13. 修复:修复 C WebSocket stmt2 自动重连 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 18. 修复:数据同步消息发送失败时,因清理内存操作导致的崩溃问题。 | ||
| 19. 修复:带有滑动(sliding)的时间窗口查询中,_wduration 结果错误的问题 | ||
| 20. 修复:窗口查询中的无效 sttblockreader 初始化动作 | ||
| 21. 修复:perf_connections 中 end_point 信息不正确的问题 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update release note for 3.3.8.4