Skip to content

Conversation

@wangmm0220
Copy link
Contributor

Description

Please briefly describe the code changes in this pull request.

Checklist

Please check the items in the checklist if applicable.

  • Is the user manual updated?
  • Are the test cases passed and automated?
  • Is there no significant decrease in test coverage?

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @wangmm0220, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the client connection capabilities by adding a new option to set 'connector information'. This allows client applications to provide details about the specific connector being used, which is then recorded and made available through the performance schema. This feature improves diagnostic capabilities and provides better insights into the types of clients connecting to the system.

Highlights

  • New Connection Option: Introduced TSDB_OPTION_CONNECTION_CONNECTOR_INFO to allow clients to specify connector-specific information.
  • Enhanced Observability: The provided connector information is now stored and exposed via the performance_schema.perf_connections table, alongside native_version.
  • Documentation Updates: Updated both English and Chinese documentation for taos_options_connection to reflect the new option and its usage, including the maximum string length of 255 characters.
  • Unit and System Tests: Added unit tests to verify the functionality of setting and truncating the connector info, and updated system tests to account for the new columns in performance_schema.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new connection option, TSDB_OPTION_CONNECTION_CONNECTOR_INFO, to allow clients to set connector information. This information, along with the native client version, is then propagated to the performance_schema.perf_connections table. The changes are well-implemented across documentation, client API, server-side logic, and tests. The code is correct and follows existing patterns. I have one suggestion to improve maintainability by reducing code duplication in one of the modified files.

@guanshengliang guanshengliang merged commit 101c8c6 into 3.3.6 Nov 5, 2025
14 of 17 checks passed
@guanshengliang guanshengliang deleted the feat/TS-6919-336 branch November 13, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants