refactor(query): refactor failed task retry control procedure.

[hjxilinx]

Description

refactor(query): refactor failed task retry control procedure.

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @hjxilinx, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant refactoring of the scheduler's failed task retry control procedure. The changes aim to enhance the robustness and clarity of how tasks are retried upon failure, particularly in scenarios involving data-bound tasks and node redirects. By simplifying data structures, introducing dedicated helper functions for retry logic and node address retrieval, and refining retry parameter initialization, the PR makes the retry mechanism more efficient and easier to understand, ultimately improving the scheduler's overall reliability.

Highlights

• Refactored Retry Control Procedure: The core logic for handling failed task retries has been significantly refactored to improve clarity and maintainability.
• Simplified Redirect Context: The SSchRedirectCtx structure was streamlined by removing several fields related to retry counting, simplifying its state management.
• New Retry and Node Address Functions: Introduced schFailedTaskNeedRetry to centralize the decision-making for task retries and schGetTaskCurrentNodeAddr to abstract the retrieval of the current node address for a task.
• Enhanced Task Retry Initialization: The schInitTaskRetryInfo function (formerly schInitTaskRetryTimes) now calculates maxRetryTimes more dynamically, considering tsMaxRetryWaitTime, redirectDelayMs, and a REPLICA_FACTOR.
• Centralized Endpoint Set Updates: A new function schUpdateCurrentEpset was added to encapsulate the logic for switching to the next endpoint in an endpoint set, improving modularity.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a solid refactoring of the failed task retry control procedure. The changes simplify the retry context SSchRedirectCtx and centralize retry logic into new helper functions like schFailedTaskNeedRetry, schUpdateCurrentEpset, and schGetTaskCurrentNodeAddr. This significantly improves code clarity and maintainability. The retry strategy is also updated, for instance, by making the retry delay fixed and recalculating max retry times. My review includes a few suggestions to further enhance readability and fix a potential logging issue.

[gemini-code-assist]

The constant REPLICA_FACTOR is defined as a local variable with a magic value of 3. To improve maintainability and code clarity, it's better to define this as a named constant at a more visible scope, for example, as a macro SCH_DEFAULT_REPLICA_FACTOR in source/libs/scheduler/inc/schInt.h. The comment explaining it is good, but a constant would make the code more self-documenting and easier to change in the future.