Skip to content

Conversation

@Pengrongkun
Copy link
Contributor

Description

Please briefly describe the code changes in this pull request.

Checklist

Please check the items in the checklist if applicable.

  • Is the user manual updated?
  • Are the test cases passed and automated?
  • Is there no significant decrease in test coverage?

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Pengrongkun, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a potential timing issue within a unit test related to statement binding. By adding a brief delay, the change aims to stabilize the test, ensuring that asynchronous operations have sufficient time to complete before the test proceeds, thereby preventing intermittent failures and improving the reliability of the test suite.

Highlights

  • Unit Test Fix: Introduced a 2-second delay (taosMsleep(2000)) in the stmt2Case, exec_retry unit test. This delay is specifically added to allow asynchronous bind operations to complete before subsequent database operations, such as dropping a table and executing a statement, are performed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a fixed sleep in a test case to handle an asynchronous operation. While this may resolve a race condition, it's a source of test flakiness and performance issues. I've provided a more robust solution that actively waits for the operation to complete by polling an internal counter, which is accessible within the test environment. This change will improve test reliability and execution speed.

checkError(stmt, code);

// wait async bind finish
taosMsleep(2000);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using a fixed-duration sleep (taosMsleep) to wait for an asynchronous operation can make tests flaky and slow. A more robust approach is to actively wait for the operation to complete. Since this is an internal test with access to internal structures, you can poll the pStmt->sql.siInfo.tbRemainNum counter, which tracks the number of pending asynchronous bind operations. This will make the test more reliable and potentially faster.

    while (atomic_load_64(&((STscStmt2*)stmt)->sql.siInfo.tbRemainNum) > 0) taosUsleep(10);

@guanshengliang guanshengliang merged commit 344099c into 3.3.6 Nov 10, 2025
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants