-
Notifications
You must be signed in to change notification settings - Fork 5k
fix:stmt2 ut #33505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:stmt2 ut #33505
Conversation
Summary of ChangesHello @Pengrongkun, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a potential timing issue within a unit test related to statement binding. By adding a brief delay, the change aims to stabilize the test, ensuring that asynchronous operations have sufficient time to complete before the test proceeds, thereby preventing intermittent failures and improving the reliability of the test suite. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a fixed sleep in a test case to handle an asynchronous operation. While this may resolve a race condition, it's a source of test flakiness and performance issues. I've provided a more robust solution that actively waits for the operation to complete by polling an internal counter, which is accessible within the test environment. This change will improve test reliability and execution speed.
| checkError(stmt, code); | ||
|
|
||
| // wait async bind finish | ||
| taosMsleep(2000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a fixed-duration sleep (taosMsleep) to wait for an asynchronous operation can make tests flaky and slow. A more robust approach is to actively wait for the operation to complete. Since this is an internal test with access to internal structures, you can poll the pStmt->sql.siInfo.tbRemainNum counter, which tracks the number of pending asynchronous bind operations. This will make the test more reliable and potentially faster.
while (atomic_load_64(&((STscStmt2*)stmt)->sql.siInfo.tbRemainNum) > 0) taosUsleep(10);
Description
Please briefly describe the code changes in this pull request.
Checklist
Please check the items in the checklist if applicable.