Drop MRI 1.8.7-2.2 support #158
Conversation
This is currently a noop.
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| expect(Appraisal::Utils.format_string(hash)). | ||
| to eq('"baz" => { :ball => "boo" }') | ||
| end | ||
| hash = { 'baz' => { :ball => 'boo' }} |
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
| hash = { :foo => 'bar' } | ||
| expect(Appraisal::Utils.format_string(hash)).to eq('foo: "bar"') | ||
| it "prints out a nice looking hash without brackets with new syntax" do | ||
| hash = { :foo => 'bar' } |
There was a problem hiding this comment.
Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
|
||
| describe '.format_arguments' do | ||
| before { stub_const('RUBY_VERSION', '1.8.7') } | ||
| before { stub_const('RUBY_VERSION', '2.3.0') } |
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
|
||
| context "git_source support" do | ||
| before { stub_const('RUBY_VERSION', '1.8.7') } | ||
| before { stub_const('RUBY_VERSION', '2.3.0') } |
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
|
||
| context "relative path handling" do | ||
| before { stub_const('RUBY_VERSION', '1.8.7') } | ||
| before { stub_const('RUBY_VERSION', '2.3.0') } |
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
|
||
| expect(Appraisal::Utils.format_arguments(arguments)).to eq( | ||
| ':foo, :bar => { :baz => "ball" }' | ||
| ':foo, bar: { baz: "ball" }' |
There was a problem hiding this comment.
Style/TrailingCommaInArguments: Put a comma after the last parameter of a multiline method call.
|
Ping! Anybody watching this repo? |
nickcharlton
left a comment
nickcharlton
left a comment
There was a problem hiding this comment.
Thanks for doing this! I'm going to merge, as this is looking great.
|
Thanks for merging! |
3 participants
These rubies are no longer maintained, and by dropping support we get inline with the range of rubies bundler supports, and get CI green.