-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Fix #9694 - Fix the misleading label for "Your Name" field #9695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #9694 - Fix the misleading label for "Your Name" field #9695
Conversation
wmontwe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix. Since the meaning of the string has changed, the string key should also be renamed to provide translators with the proper context.
e151901 to
e9b92ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I trimmed your changes down to the en strings, since that’s what Weblate uses as the basis for translations. No further changes are needed.
Dev note: We need to update the translation instructions as they are not accurate anymore, will patch them as part of #9498
|
@wmontwe - I am seeing an error in CI. Looks like having extra strings causes a build failure. |
e9b92ed to
f216759
Compare
I fixed it, our instructions on how to deal with |
|
Thanks for your contribution! Your pull request has been merged and will be part of Thunderbird 14. We appreciate the time and effort you put into improving Thunderbird. If you haven’t already, you’re welcome to join our Matrix chat for contributors. It’s where we discuss development and help each other out. https://matrix.to/#/#tb-android-dev:mozilla.org |
This PR fixes #9694