Skip to content

Conversation

@vivganes
Copy link
Contributor

This PR fixes #9694

Copy link
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix. Since the meaning of the string has changed, the string key should also be renamed to provide translators with the proper context.

@vivganes vivganes requested a review from wmontwe September 4, 2025 05:05
@wmontwe wmontwe force-pushed the fix-misleading-your-name-label branch 2 times, most recently from e151901 to e9b92ed Compare September 4, 2025 09:18
wmontwe
wmontwe previously approved these changes Sep 4, 2025
Copy link
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I trimmed your changes down to the en strings, since that’s what Weblate uses as the basis for translations. No further changes are needed.

Dev note: We need to update the translation instructions as they are not accurate anymore, will patch them as part of #9498

@vivganes
Copy link
Contributor Author

vivganes commented Sep 4, 2025

@wmontwe - I am seeing an error in CI. Looks like having extra strings causes a build failure.

"account_setup_options_display_name_label" is translated here but not found in default locale [ExtraTranslation]

@wmontwe wmontwe force-pushed the fix-misleading-your-name-label branch from e9b92ed to f216759 Compare September 4, 2025 10:01
@wmontwe
Copy link
Member

wmontwe commented Sep 4, 2025

@wmontwe - I am seeing an error in CI. Looks like having extra strings causes a build failure.

"account_setup_options_display_name_label" is translated here but not found in default locale [ExtraTranslation]

I fixed it, our instructions on how to deal with en source strings need an update.

@rafaeltonholo rafaeltonholo merged commit 41de7d9 into thunderbird:main Sep 4, 2025
3 checks passed
@thunderbird-botmobile
Copy link
Contributor

Thanks for your contribution! Your pull request has been merged and will be part of Thunderbird 14. We appreciate the time and effort you put into improving Thunderbird. If you haven’t already, you’re welcome to join our Matrix chat for contributors. It’s where we discuss development and help each other out. https://matrix.to/#/#tb-android-dev:mozilla.org
Hope to see you there! 🚀📱🐦

@thunderbird-botmobile thunderbird-botmobile bot added this to the Thunderbird 14 milestone Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confusing (possibly misleading) label in "Account Display Options" for en

3 participants