add ETH support for LILYGO-POE-Pro #4030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also includes minor spelling corrections for CONTRIBUTING.md
|
I have the same board and just reinvented the wheel myself without knowing this PR existed. I also use this board with the onboard RS485 adapter for DMX, for this i also needed to change the TX pin in |
Contributor
Author
|
That's a great idea! Maybe we can make the DMX tx pin configurable? I'm glad I'm not the only one who saw potential in this board - I'm excited to wrap up my first project with it! |
Contributor
|
Please keep DMX changes to a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes minor spelling corrections for
CONTRIBUTING.mdVerified these settings using my LILYGO-POE-Pro board. I confirmed the connection is only over Ethernet, no Wifi.