Backport fix ESP8266 DMA off-by-one to 0.15 #5139
Merged
+138
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shim in Makuna/NeoPixelBus#894 until approved by upstream. Fixes wled#4906 and wled#5136.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
DedeHai
approved these changes
Dec 1, 2025
Collaborator
DedeHai
left a comment
DedeHai
left a comment
There was a problem hiding this comment.
confirmed: fixes the 52LED & output 3 issue
willmmiles
added a commit
to willmmiles/WLED
that referenced
this pull request
Dec 2, 2025
Includes bonus fix for ESP32 DMA driver, too! Replaces wled#5139.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shim in Makuna/NeoPixelBus#894 until approved by upstream.
Backport of #5138