Fix TypeError when loading UI with custom palette selected #5205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a custom palette is selected and the page reloads,
updateSelectedPalette()is called before custom palettes are added to the DOM, causingTypeError: Cannot read properties of null (reading 'querySelector').Root Cause
During initialization, the sequence is:
loadPalettes()builds palette list with base palettes onlyrequestJson()→readState()→updateUI()→updateSelectedPalette()lastinfo.cpalcountfrom step 2)Changes
Added early return when palette element doesn't exist:
The palette is correctly selected later when
populatePalettes()re-runs with custom palettes.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.