Skip to content

Conversation

@awpr
Copy link
Member

@awpr awpr commented Aug 15, 2015

No description provided.

@awpr
Copy link
Member Author

awpr commented Aug 15, 2015

Finally finished rebasing my changes onto the recent priority changes. I added a hack to close all streams immediately and confirmed that without this change, this made the whole connection end, and with the change, the connection survived.

@awpr
Copy link
Member Author

awpr commented Aug 15, 2015

Context: my comment on #423

@awpr
Copy link
Member Author

awpr commented Aug 15, 2015

(the diff looks big, but it's basically just indenting a bunch of lines by 4 spaces and moving 'loop' outside of 'unlessClosed').

@creichert
Copy link
Member

BTW, you can diff with no whitespace using the w=1 query parameter. https://github.com/yesodweb/wai/pull/424/files?w=1

creichert added a commit that referenced this pull request Aug 16, 2015
Continue with the Sender loop despite closed streams
@creichert creichert merged commit cc4c1bc into yesodweb:master Aug 16, 2015
@creichert
Copy link
Member

@awpr This is great stuff, thanks a lot

@kazu-yamamoto
Copy link
Contributor

@awpr Please separate "layout change only" commits and other commits. If mixed, it's quite hard to review.

@kazu-yamamoto
Copy link
Contributor

The point is that loop is the outside of unlessClosed, right?

@kazu-yamamoto
Copy link
Contributor

@awpr Sorry for my previous comment. Your patch does not include "layout change only".

@kazu-yamamoto
Copy link
Contributor

Now I understand the patch completely. Again, sorry for my confusion.

@kazu-yamamoto
Copy link
Contributor

A new version has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants