Skip to content

Conversation

@ChickenProp
Copy link
Contributor

@ChickenProp ChickenProp commented Jul 14, 2018

Previously, in this situation the logger would be passed a dummy
request, with no path or method data. Now the logger sees the actual
request, and can log it appropriately.

Before submitting your PR, check that you've:

  • Bumped the version number

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

Previously, in this situation the logger would be passed a dummy
request, with no path or method data. Now the logger sees the actual
request, and can log it appropriately.
Copy link
Member

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snoyberg snoyberg merged commit 89f81ce into yesodweb:master Jul 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants