Use lookupEnv instead of getEnvironment #736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Travis does not actually fail to build this. It just timed out when building with GHC 8.2.2 for some reason. |
snoyberg
approved these changes
Mar 30, 2019
Member
snoyberg
left a comment
snoyberg
left a comment
There was a problem hiding this comment.
Thanks! Was there a specific motivation for this beyond code cleanup?
Contributor
Author
|
Not really. I was just looking through the implementations of the various runner functions to see how they were related, and I noticed that the environment lookup was goofy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.