Skip to content

Conversation

@kazu-yamamoto
Copy link
Contributor

I have extracted HTTP/2 implementation in warp and moved it to Network.HTTP2.Server in http2. This results in so beautiful APIs and I feel it's promising. It is independent from WAI hoping that other HTTP engines can use it. http2 version 2.0.0 has been already released.

This PR deletes many modules relating to HTTP/2 and uses Network.HTTP2.Server. This implementation passes all tests on my local machine including h2spec. Field testing has been done at least two weeks in my web site.

@snoyberg This PR is to telling Warp guys that a big change is coming. Please give a look and tell me if you find something wrong.

@kazu-yamamoto kazu-yamamoto requested a review from snoyberg June 21, 2019 01:54
@kazu-yamamoto
Copy link
Contributor Author

@kazu-yamamoto
Copy link
Contributor Author

@snoyberg
Copy link
Member

I didn't look that thoroughly, but a cursory review looks fine to me. I'm happy with this kind of direction too, thanks for pursuing it. If you're comfortable with it, I'd say go ahead with such a release.

kazu-yamamoto added a commit to kazu-yamamoto/wai that referenced this pull request Jun 24, 2019
kazu-yamamoto added a commit to kazu-yamamoto/wai that referenced this pull request Jun 24, 2019
@kazu-yamamoto kazu-yamamoto merged commit 2e21fe3 into yesodweb:master Jun 24, 2019
@kazu-yamamoto kazu-yamamoto deleted the http2-server branch June 24, 2019 00:35
@kazu-yamamoto
Copy link
Contributor Author

Thank you for reviewing!
Rebased and merged.

@kazu-yamamoto
Copy link
Contributor Author

@snoyberg I'm trying to fix tests on Azure CI.
Since doctest fails even on my local machine at this moment, I disabled it.
Now only Linux cabal-7.10.3 fails.
Would you give a look?
Because I think that this is not due to the HTTP/2 server library, I will release a new version of warp.

@snoyberg
Copy link
Member

Looks like it's a problem of old Cabal versions not liking the Strict and StrictData extensions for upload to Hackage. I'll try to put in a workaround.

@kazu-yamamoto
Copy link
Contributor Author

I saw green! Thank you very much!

@snoyberg
Copy link
Member

My pleasure, thanks for all the other fixes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants