Fix Appearance picker focus and selection states#2894
Merged
Conversation
Unify focus and selection rings to both target the illustration instead of the container. Use frame-text for selection and frame-theme (blue) for focus. Bold the label when selected, blue label on focus. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
📊 Performance Test ResultsComparing 88caab0 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
sejas
approved these changes
Mar 25, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
katinthehatsite
approved these changes
Apr 2, 2026
katinthehatsite
left a comment
Contributor
There was a problem hiding this comment.
Thanks for changing the labels, I think it looks better now 😍
I will retrigger the failing tests as they seem to be unrelated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


The recent addition of Appearance settings for light/dark mode introduced new UI in our app settings. I noticed that the focus state is a little awkward.
Here's how it looks with Light selected and in focus:
And here's with Light selected and Dark in focus:
This PR aims to unify the ring for both selection and focus states, with the color and font-weight to help distinguish between selected and focused.
Selected, and focused:

Selected, but unfocused:

Light mode, both selected (Light) and focused (Dark):

How AI was used in this PR
Claude helped implement the CSS changes. All changes were reviewed and iterated on interactively.
Proposed Changes
frame-textcolor for the selection ring to distinguish it from the blue focus ring (frame-theme)frame-theme) on focusgroup-focusinstead ofgroup-focus-visibleso clicking an option shows both focus and selection states (consistent with standard input behavior)Testing Instructions
🤖 Generated with Claude Code