GS/HW: Better handle some texture creation hazards.#14631
Merged
Conversation
Contributor
|
Might be good to wait to rebase this on top of ROV revisions, since ConvertDepthFormatROV() is renamed and changed completely. |
lightningterror
force-pushed
the
gs_tex_hazards
branch
from
775137b to
cd8632a
Compare
BeginDSAsRT and ConvertTextureTypeROVSingle make sure the textures are actually created.
lightningterror
force-pushed
the
gs_tex_hazards
branch
from
cd8632a to
a8cbd91
Compare
TJnotJT
approved these changes
Jun 29, 2026
TJnotJT
left a comment
TJnotJT
left a comment
Contributor
There was a problem hiding this comment.
Changes look fine, haven't tested personally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
GS/HW: Better handle some texture creation hazards.
BeginDSAsRT and ConvertTextureTypeROVSingle make sure the textures are actually created.
Rationale behind Changes
Potential crash fixes if we fail to allocate textures.
Suggested Testing Steps
Test if ROV works, test if ds as rt works: FFX is a good testcase with and without rov using aa1.
Did you use AI to help find, test, or implement this issue or feature?
No.