Skip to content

Fix typo in Autocomplete component README.md#63496

Merged
t-hamano merged 3 commits into
WordPress:trunkfrom
barryceelen:patch-1
Jul 13, 2024
Merged

Fix typo in Autocomplete component README.md#63496
t-hamano merged 3 commits into
WordPress:trunkfrom
barryceelen:patch-1

Conversation

@barryceelen

@barryceelen barryceelen commented Jul 12, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@barryceelen barryceelen requested a review from ajitbohra as a code owner July 12, 2024 17:43
@github-actions

github-actions Bot commented Jul 12, 2024 •
edited
Loading

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: barryceelen <barryceelen@git.wordpress.org>
Co-authored-by: shail-mehta <shailu25@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@shail-mehta shail-mehta added the [Type] Developer Documentation Documentation for developers label Jul 13, 2024
shail-mehta
shail-mehta reviewed Jul 13, 2024
View reviewed changes

@shail-mehta shail-mehta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Catch👍

t-hamano
t-hamano reviewed Jul 13, 2024
View reviewed changes

@t-hamano t-hamano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@barryceelen Thanks for the PR. How about changing the following line as well?

gutenberg/packages/components/src/autocomplete/types.ts

Line 203 in 4e21760

* Whether or not the Autocomplte componenet is selected, and if its

@t-hamano t-hamano added the [Package] Components /packages/components label Jul 13, 2024
Mamaduka
Mamaduka approved these changes Jul 13, 2024
View reviewed changes

@Mamaduka Mamaduka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, @barryceelen!

@barryceelen

barryceelen commented Jul 13, 2024

Copy link
Copy Markdown
Contributor Author

How about changing the following line as well?

@t-hamano fixed!

t-hamano
t-hamano approved these changes Jul 13, 2024
View reviewed changes

@t-hamano t-hamano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@t-hamano t-hamano merged commit a48b1ff into WordPress:trunk Jul 13, 2024
@github-actions github-actions Bot added this to the Gutenberg 18.9 milestone Jul 13, 2024
@barryceelen barryceelen deleted the patch-1 branch July 13, 2024 18:32
scruffian pushed a commit that referenced this pull request Jul 15, 2024
@barryceelen @t-hamano
@Mamaduka @scruffian
Fix typo in Autocomplete component README.md (#63496)
0c06f14 
* Fix typo in Autocomplete component README.md

* Fix typo in Autocomplete component README.md

* Fix typo in Autocomplete component README.md

Co-authored-by: barryceelen <barryceelen@git.wordpress.org>
Co-authored-by: shail-mehta <shailu25@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jul 18, 2024
@barryceelen @t-hamano
@Mamaduka @carstingaxion
Fix typo in Autocomplete component README.md (WordPress#63496)
85a9112 
* Fix typo in Autocomplete component README.md

* Fix typo in Autocomplete component README.md

* Fix typo in Autocomplete component README.md

Co-authored-by: barryceelen <barryceelen@git.wordpress.org>
Co-authored-by: shail-mehta <shailu25@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shail-mehta shail-mehta shail-mehta left review comments
@Mamaduka Mamaduka Mamaduka approved these changes
@t-hamano t-hamano t-hamano approved these changes
@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

No one assigned

Labels

[Package] Components /packages/components [Type] Developer Documentation Documentation for developers

Projects

None yet

Milestone

Gutenberg 18.9

Development

Successfully merging this pull request may close these issues.

4 participants

@barryceelen @Mamaduka @shail-mehta @t-hamano