Skip to content

Check synctatic correctness for code-snippets#16005

Merged
mik-laj merged 4 commits into
apache:masterfrom
mik-laj:blacken
May 27, 2021
Merged

Check synctatic correctness for code-snippets#16005
mik-laj merged 4 commits into
apache:masterfrom
mik-laj:blacken

Conversation

@mik-laj

@mik-laj mik-laj commented May 23, 2021

Copy link
Copy Markdown
Member

Some code snippets, although marked as Python code, were not valid Python code. I add blacken-docs to detect such snippets.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@github-actions

Copy link
Copy Markdown
Contributor

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@mik-laj mik-laj changed the title Check syctatic correctness for code-snippets Check synctatic correctness for code-snippets May 24, 2021
@mik-laj

mik-laj commented May 26, 2021

Copy link
Copy Markdown
Member Author

@potiuk Can you look at iit?

@github-actions

Copy link
Copy Markdown
Contributor

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions Bot added the full tests needed We need to run full set of tests for this PR to merge label May 26, 2021
@mik-laj mik-laj merged commit 904709d into apache:master May 27, 2021
@eladkal eladkal mentioned this pull request May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools area:providers full tests needed We need to run full set of tests for this PR to merge kind:documentation provider:amazon AWS/Amazon - related issues provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants