Skip to content

Correctly restore upstream_task_ids when deserializing Operators#8775

Merged
ashb merged 1 commit into
apache:masterfrom
astronomer:s10n-upstream-task-id-fix
May 10, 2020
Merged

Correctly restore upstream_task_ids when deserializing Operators#8775
ashb merged 1 commit into
apache:masterfrom
astronomer:s10n-upstream-task-id-fix

Conversation

@ashb

@ashb ashb commented May 7, 2020

Copy link
Copy Markdown
Member

This test exposed a bug in one of the example dags, that wasn't caught by #6549. That will be a fixed in a separate issue, but it caused the round-trip tests to fail here

Fixes #8720


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@ashb ashb requested a review from kaxil May 7, 2020 23:04
@boring-cyborg boring-cyborg Bot added area:serialization provider:google Google (including GCP) related issues labels May 7, 2020
@ashb ashb marked this pull request as draft May 7, 2020 23:04

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@potiuk @mik-laj This change should be okay, right? (I can't think of any reason why it wouldn't be)

@kaxil

kaxil commented May 9, 2020

Copy link
Copy Markdown
Member

Tested this PR fixes #8720 :

May-09-2020 19-09-54

@kaxil kaxil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on the last commit.

d3defcf

We will need to merge #8772 before we merge this

This test exposed a bug in one of the example dags, that wasn't caught
by apache#6549. That will be a fixed in a separate issue, but it caused the
round-trip tests to fail here

Fixes apache#8720
@ashb ashb force-pushed the s10n-upstream-task-id-fix branch from d3defcf to 0618800 Compare May 10, 2020 07:59
@ashb ashb marked this pull request as ready for review May 10, 2020 07:59
@ashb ashb merged commit 280f1f0 into apache:master May 10, 2020
@ashb ashb added this to the Airflow 1.10.11 milestone May 10, 2020
@ashb ashb removed the provider:google Google (including GCP) related issues label May 10, 2020
@ashb ashb deleted the s10n-upstream-task-id-fix branch May 10, 2020 12:40
ashb added a commit to astronomer/airflow that referenced this pull request May 18, 2020
…che#8775)

This test exposed a bug in one of the example dags, that wasn't caught
by apache#6549. That will be a fixed in a separate issue, but it caused the
round-trip tests to fail here

Fixes apache#8720

(cherry picked from commit 280f1f0)
kaxil pushed a commit that referenced this pull request Jun 26, 2020
This test exposed a bug in one of the example dags, that wasn't caught
by #6549. That will be a fixed in a separate issue, but it caused the
round-trip tests to fail here

Fixes #8720

(cherry picked from commit 280f1f0)
potiuk pushed a commit that referenced this pull request Jun 29, 2020
This test exposed a bug in one of the example dags, that wasn't caught
by #6549. That will be a fixed in a separate issue, but it caused the
round-trip tests to fail here

Fixes #8720

(cherry picked from commit 280f1f0)
@kaxil kaxil added the type:bug-fix Changelog: Bug Fixes label Jul 1, 2020
kaxil pushed a commit that referenced this pull request Jul 1, 2020
This test exposed a bug in one of the example dags, that wasn't caught
by #6549. That will be a fixed in a separate issue, but it caused the
round-trip tests to fail here

Fixes #8720

(cherry picked from commit 280f1f0)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
…che#8775)

This test exposed a bug in one of the example dags, that wasn't caught
by apache#6549. That will be a fixed in a separate issue, but it caused the
round-trip tests to fail here

Fixes apache#8720

(cherry picked from commit 280f1f0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't clear all upstream tasks when DAG Serialization is enabled

2 participants