[v0.2.x] containerd: ignore SIGPIPE#930
Merged
Merged
Conversation
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
Member
|
LGTM |
40 tasks
runcom
added a commit
to runcom/containerd
that referenced
this pull request
Jun 27, 2017
This PR containerd#930 ignored SIGPIPE signals but we aren't actually subscribed to receive them (and ignore them). This patch adds the missing piece by subscribing to receive SIGPIPE(s). Signed-off-by: Antonio Murdaca <runcom@redhat.com>
mlaventure
pushed a commit
to mlaventure/containerd
that referenced
this pull request
Jul 4, 2017
This PR containerd#930 ignored SIGPIPE signals but we aren't actually subscribed to receive them (and ignore them). This patch adds the missing piece by subscribing to receive SIGPIPE(s). Signed-off-by: Antonio Murdaca <runcom@redhat.com> (cherry picked from commit 6a7b7d2) Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
Merged
mlaventure
pushed a commit
to mlaventure/containerd
that referenced
this pull request
Aug 7, 2017
This PR containerd#930 ignored SIGPIPE signals but we aren't actually subscribed to receive them (and ignore them). This patch adds the missing piece by subscribing to receive SIGPIPE(s). Signed-off-by: Antonio Murdaca <runcom@redhat.com> (cherry picked from commit 6a7b7d2) Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #580
As already stated in moby/moby#19728, this is meant as a temporary workaround cause it's far worse to have dockerd/containerd silently go away. We have people working on a proper fix though.
Signed-off-by: Antonio Murdaca runcom@redhat.com