Adapt chart line output to accept multiple filters#78
Merged
Conversation
Contributor
Author
|
I have fixed the error. It came from the fact that I thought the plotter could draw lines based on their local minimums and maximums, but that doesn't seem to be the case. I have amended the |
Owner
cyberbit
requested changes
Dec 31, 2024
cyberbit
left a comment
Owner
There was a problem hiding this comment.
Just a few minor changes but otherwise lgtm!
cyberbit
approved these changes
Dec 31, 2024
Owner
|
Looks great, merged! Thanks again for contributing 🩵 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

As outlined in #77, this is my proposed API change for
ChartLineOutputAdapter.lua. I also amended the filter structure toThe only caveat so far is an error that pops up right at the start of series, apparently by a nil value in the plot data? I cannot figure out where it's coming from... It doesn't affect the output but if I can solve it, I will amend the PR.