Add support for 4GB memory option#842
Merged
Merged
Conversation
added 2 commits
January 8, 2021 08:43
The 4GB memory option was not added everywhere. Fixes firebase#834
joehan
approved these changes
Jan 12, 2021
joehan
left a comment
joehan
left a comment
Member
There was a problem hiding this comment.
LGTM, sorry for the oversight!
Member
|
firebase/firebase-tools#3026 filed this PR in firebase-tools to support this option in the functions emulator as well. |
Contributor
Author
|
@joehan When do you think there will be a new version released? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The 4GB memory option was not added everywhere.
Fixes #834
Tests are added verifying that the 4GB option works