Skip to content

Bump up archiver package version to stop producing bad zip archives in nodejs15#3140

Merged
taeold merged 2 commits into
masterfrom
dl-bump-archiver-v
Feb 16, 2021
Merged

Bump up archiver package version to stop producing bad zip archives in nodejs15#3140
taeold merged 2 commits into
masterfrom
dl-bump-archiver-v

Conversation

@taeold

@taeold taeold commented Feb 16, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Bump up the archiver version to the latest that includes the necessary patch to fix functions deploys on nodejs15.

We are using an old version of the archiver package that doesn't include the patch addressing invalid zip files in nodejs15 (archiverjs/node-archiver#491).

In the past 2 major versions, the archiver package introduced following breaking changes (tl;dr - they don't break us!):

  • breaking: slowly catch up with node LTS, remove support for versions under 8.
    • No action required: firebase cli does not support nodejs version <8.
  • breaking: absolute path glob patterns are no longer supported: use cwd option instead.
    • No action required: we don't use archiver.glob in our code.

Fixes #3120

Scenarios Tested

$ node -v
v15.8.0
$ firebase deploy
....
✔  Deploy complete!

@google-cla google-cla Bot added the cla: yes Manual indication that this has passed CLA. label Feb 16, 2021
@taeold taeold requested review from inlined and joehan February 16, 2021 05:38
@taeold taeold marked this pull request as ready for review February 16, 2021 05:38
bkendall
bkendall approved these changes Feb 16, 2021
View reviewed changes

@bkendall bkendall left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for checking the release notes for changes! :) Suggestion for wording in the changelog...

Comment thread CHANGELOG.md Outdated
@taeold @bkendall
Update CHANGELOG.md
c74c3cf 
Co-authored-by: Bryan Kendall <bkend@google.com>
@taeold taeold merged commit ca9112e into master Feb 16, 2021
@taeold taeold deleted the dl-bump-archiver-v branch February 16, 2021 17:51
@taeold taeold mentioned this pull request Feb 27, 2021
Closed
devpeerapong pushed a commit to devpeerapong/firebase-tools that referenced this pull request Dec 14, 2021
@taeold @devpeerapong
Bump up archiver package version to stop producing bad zip archives i…
807b90e 
…n nodejs15 (firebase#3140)

Bump up archiver package version to fix  bad zip files in nodejs15.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkendall bkendall bkendall approved these changes

@joehan joehan Awaiting requested review from joehan

@inlined inlined Awaiting requested review from inlined

Assignees

No one assigned

Labels

cla: yes Manual indication that this has passed CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Function deployment fails when running on Node 15.8.0

2 participants

@taeold @bkendall