Plural form

[milotype]

Describe the problem that you'd like solved

Please use plural form for the following string:

#: trending.html:26
#, python-format
msgid "Logged %(count)i times %(time_unit)s"
msgstr ""

[milotype]

Ther is another instance for using plural forms.

REQUEST:
Please merge the following strings into one string with plural form:

#: StarRatingsByline.html StarRatingsComponent.html
msgid "rating"
msgstr "ocjena"

#: StarRatingsByline.html StarRatingsComponent.html
msgid "ratings"
msgstr "ocjene"

SOLUTION:
The merged string should be something like (for Croatian):

#: StarRatingsByline.html StarRatingsComponent.html
#, python-format
msgid "rating"
msgid_plural "ratings"
msgstr[0] ""
msgstr[1] ""
msgstr[2] ""

I'm not a programmer, so please excuse if my solution is not correct.

P.S.
I hope it's OK to add another issue wich is related to the original issue. :-)

[milotype]

@mekarpeles @cdrini

• Please change the label for this issue to label:"Type: Bug".
• I probably used the wrong issue type when I reported the issue.
• If possible correct the two mentioned problems soon. :-) I've reported it back in January 2023!

Please provide an example of the generated result for the string:

• msgid "Logged %(count)i times %(time_unit)s"

Thank you

[tfmorris]

This is an anti-pattern that appears persistently where the developer tried to do their own formatting rather than let the i18n functions do it.

openlibrary/openlibrary/macros/StarRatingsComponent.html

Lines 4 to 5 in 45bfba0

	$ formatted_ratings_count = "{:,}".format(ratings_count) if ratings_count else ""
	$ ratings_label = _('rating') if ratings_count == 1 else _('ratings')

openlibrary/openlibrary/macros/StarRatingsByline.html

Lines 3 to 4 in 45bfba0

	$ formatted_want_to_read_count = "{:,}".format(want_to_read_count) if want_to_read_count else ""
	$ ratings_label = _('rating') if ratings_count == 1 else _('ratings')

The string needs to include replaceable parameters for the number(s) and number formatting needs to be done in a locale-aware fashion (which means the formatting function needs the user's language).

Another I noticed over the weekend is the work count on the languages page, although the root cause for that is slightly different, so I'll open a separate issue for it.