Fix/fixes to contributing.md#12184
Merged
Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…into fix/fix-wiki-links
…into fix/fix-wiki-links
Contributor
There was a problem hiding this comment.
Pull request overview
Updates CONTRIBUTING.md to adjust formatting and modernize references (notably around testing guidance) for contributors reading the project’s contribution workflow.
Changes:
- Adds a top-of-file separator (
---) and minor spacing/blank-line adjustments. - Cleans up the “Picking Good First Issues” paragraph formatting.
- Replaces the old testing link and removes the embedded pre-commit hooks section in favor of a single docs link.
|
|
||
| > **_Warning:_** If you don't clone with **ssh** then infogami will have pre-commit issues [You can read this section to resolve it](docker/README.md#cloning-the-open-library-repository). | ||
|
|
||
| See https://docs.openlibrary.org/developers/tools/testing.html for more information. |
There was a problem hiding this comment.
The Testing section now only contains a bare URL and drops the previous local guidance about using pre-commit. Since this repo is configured to use pre-commit (see .pre-commit-config.yaml) and contributors are told elsewhere that a pre-commit bot may push commits, consider keeping a short pre-commit pointer here (or linking to the relevant docs) and format the URL as a Markdown link for readability.
Suggested change
| See https://docs.openlibrary.org/developers/tools/testing.html for more information. | |
| See the [testing guide](https://docs.openlibrary.org/developers/tools/testing.html) for more information, including how to run tests locally. This repository also uses [`pre-commit`](https://pre-commit.com); consider installing it so you can run the same checks locally before you push. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
RayBB
reviewed
Mar 24, 2026
RayBB
approved these changes
Mar 24, 2026
RayBB
left a comment
RayBB
left a comment
Collaborator
There was a problem hiding this comment.
Exactly what we discussed. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes and changes to CONTRIBUTING.md
Stakeholders
@RayBB