Migrate public_observations endpoint to FastAPI#12205
Merged
RayBB merged 5 commits intoMar 31, 2026
Merged
Conversation
RayBB
reviewed
Mar 27, 2026
8 tasks
Sanket17052006
force-pushed
the
migrate-public_observations-fastapi
branch
from
95f64d0 to
492a004
Compare
github-project-automation
Bot
moved this to Waiting Review/Merge from Staff
in Ray's Project
Member
|
cc'ing @jimchamp as a stakeholder in case he has comments (as I believe he wrote some of this original code for observations) |
RayBB
approved these changes
Mar 31, 2026
RayBB
left a comment
RayBB
left a comment
Collaborator
There was a problem hiding this comment.
Excellent work here.
I simplified the code just a bit and pushed that up.
Tested this on testing and it's working like a charm.
@jimchamp would love to know if this is actually used and if so how? I don't see it in the frontend but sometimes it's hidden.
github-project-automation
Bot
moved this from Waiting Review/Merge from Staff
to Done
in Ray's Project
IvanPisquiy06
pushed a commit
to IvanPisquiy06/openlibrary
that referenced
this pull request
Apr 27, 2026
Co-authored-by: RayBB <RayBB@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #11999
This PR migrates the public_observations legacy endpoint to FastAPI.
Changes :-
openlibrary/fastapi/internal/api.py- Added the FastAPI public observations endpoint.openlibrary/plugins/openlibrary/api.py- Deprecated the web.py endpoint.openlibrary/tests/fastapi/test_public_observations.py- Added test file.Testing
./tests/integration/temporary/test_observation.shdocker compose exec web pytest openlibrary/tests/fastapi/test_public_observations.py -vScreenshot
N/A
Stakeholders
@RayBB