Skip to content

Bumped precommit with sqlfluff version 4.1.0#12243

Merged
RayBB merged 2 commits into
internetarchive:masterfrom
Sanket17052006:stop-excluding-files-in-sqlfluff-11919
Apr 2, 2026
Merged

Bumped precommit with sqlfluff version 4.1.0#12243
RayBB merged 2 commits into
internetarchive:masterfrom
Sanket17052006:stop-excluding-files-in-sqlfluff-11919

Conversation

@Sanket17052006

Copy link
Copy Markdown
Contributor

Closes #11919

Changes:

  • Bumped sqlfluff from 4.0.4 to 4.1.0 .
  • Removed prod-partial-dump.sql from the exclusion list — it had fixable linting issues.
  • Updated the exclusion comments to describe why the remaining two files are excluded.
  1. patron_data.sql — contains raw tab-separated COPY data rows with \N nulls that sqlfluff cannot parse.
  2. import-partial.sql — uses a psql variable placeholder (:source) inside a standard SQL COPY command that sqlfluff cannot parse

Testing

  • pre-commit run --all-files
  • docker compose run --rm home make test

Screenshot

N/A

Stakeholders

@RayBB

@github-project-automation github-project-automation Bot moved this to Waiting Review/Merge from Staff in Ray's Project Apr 1, 2026
@RayBB

RayBB commented Apr 1, 2026

Copy link
Copy Markdown
Collaborator

@Sanket17052006 can you please open two new issues in the sqlfluff repo for the two features that are missing?
Just like someone did here: sqlfluff/sqlfluff#7512

Then link them in this PR.

@Sanket17052006

Copy link
Copy Markdown
Contributor Author

I have opened the issues sqlfluff/sqlfluff#7696 and sqlfluff/sqlfluff#7697 for the missing features.

@RayBB RayBB left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please create a new issue (similar to the one you're closing) mentioning the two new issues you created and saying we should update the pre-commit rule when those are merged.

Then in .pre-commit-config.yaml please mention that issue number in the comment so people know to go look at it when they wonder why we have these exceptions.

In any case, this is looking go so far and your work is appreciated! 👍

@Sanket17052006

Copy link
Copy Markdown
Contributor Author

Thank you! @RayBB, I created issue #12245 and the mentioned the sqlfluff issues.
Also updated the .pre-commit-config.yaml comment to reference it.

@github-actions github-actions Bot added the Needs: Response Issues which require feedback from lead label Apr 1, 2026

@RayBB RayBB left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally pre-commit is working. Also these small changes to the query look very safe to me.

CC: @cdrini since he's the solr guru.

Thanks for your work following up on this one!

@RayBB RayBB merged commit 2f340b6 into internetarchive:master Apr 2, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this from Waiting Review/Merge from Staff to Done in Ray's Project Apr 2, 2026
IvanPisquiy06 pushed a commit to IvanPisquiy06/openlibrary that referenced this pull request Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Response Issues which require feedback from lead

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Stop excluding files in sqlfluff when a version > 4.0.4 is out.

2 participants