Bumped precommit with sqlfluff version 4.1.0#12243
Merged
RayBB merged 2 commits intoApr 2, 2026
Merged
Conversation
Collaborator
|
@Sanket17052006 can you please open two new issues in the sqlfluff repo for the two features that are missing? Then link them in this PR. |
Contributor
Author
|
I have opened the issues sqlfluff/sqlfluff#7696 and sqlfluff/sqlfluff#7697 for the missing features. |
RayBB
requested changes
Apr 1, 2026
RayBB
left a comment
Collaborator
There was a problem hiding this comment.
Could you please create a new issue (similar to the one you're closing) mentioning the two new issues you created and saying we should update the pre-commit rule when those are merged.
Then in .pre-commit-config.yaml please mention that issue number in the comment so people know to go look at it when they wonder why we have these exceptions.
In any case, this is looking go so far and your work is appreciated! 👍
Contributor
Author
IvanPisquiy06
pushed a commit
to IvanPisquiy06/openlibrary
that referenced
this pull request
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11919
Changes:
4.0.4to4.1.0.patron_data.sql— contains raw tab-separated COPY data rows with \N nulls that sqlfluff cannot parse.import-partial.sql— uses a psql variable placeholder (:source) inside a standard SQL COPY command that sqlfluff cannot parseTesting
pre-commit run --all-filesdocker compose run --rm home make testScreenshot
N/A
Stakeholders
@RayBB