Fix solr-updater and book page errors when invalid identifier#12547
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens Solr edition document building (and upstream identifier rendering) against None identifier values, preventing solr-updater crashes like those described in #12546.
Changes:
- Filter out
Noneidentifier values when building edition Solr identifier fields. - Skip
Noneidentifier values when processing identifiers in the upstream models layer (prevents page/render-time errors). - Add a focused unit test validating identifier key normalization and
Nonefiltering behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| openlibrary/solr/updater/edition.py | Filters None values out of edition identifier lists before calling .strip() and emitting Solr fields. |
| openlibrary/plugins/upstream/models.py | Skips None identifier values during _process_identifiers() to avoid downstream string operations failing. |
| openlibrary/tests/solr/updater/test_edition.py | Adds coverage for EditionSolrBuilder.identifiers with weird keys and None values. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #12546 . Handles making solr-updater and the book page resilient to
Noneidentifiers.Technical
Testing
Now renders correctly on testing: https://testing.openlibrary.org/works/OL45259313W/Yely%27s_Holiday_Traditions
Screenshot
Stakeholders