Add range validation to is_valid_date for month and day (#12754)

[tranmin001]

Closes #12754

[fix]

Technical

Adds range validation to is_valid_date in openlibrary/plugins/upstream/checkins.py. The function previously only checked whether year was truthy and whether day required a month, but performed no range checks on the values themselves. This meant is_valid_date(2024, 13, None) returned True. The fix adds two guards after the year check: month must be between 1 and 12 when provided, and day must be between 1 and 31 when provided.

Open to any feedback or change!

Testing

Added test_month_out_of_range, test_day_out_of_range, and test_boundary_values to TestIsValidDate in openlibrary/plugins/upstream/tests/test_checkins.py.

To run:
sudo docker compose run --rm home pytest openlibrary/plugins/upstream/tests/test_checkins.py::TestIsValidDate -v

Ran make test locally — 3850 tests passed, 15 failed. New tests: 4 passed, 0 failed.

• The 15 failures are pre-existing Pydantic/FastAPI compatibility errors in test_list_view_json.py, test_lists_json.py, and test_search.py, unrelated to this change.

Stakeholders

@jimchamp @mekarpeles

[mekarpeles]

Thank you for this contribution, @tranmin001.

🤖 Copilot has been assigned for an initial review.

@jimchamp is assigned to this PR and currently has:

• 7 open PR(s) of equal or higher priority to review first

PR triage checklist (maintainers / Pam)

• PR description — not empty; explains what the change does and how to verify it
• References an issue — PR body contains a #NNN reference
  • Linked issue is triaged — has a Priority: * label (not just Needs: Triage)
  • Linked issue is assigned — has at least one assignee
• Commit history clean — no WIP/fixup/conflict noise; commit messages are meaningful
• CI passing — no failing check-runs
• Test cases present — if the change touches substantive logic, test coverage exists or is explained
• Proof of testing — PR body includes a description of what was tested, a screenshot, or a video

Note

This comment was automatically generated by Pam, Open Library's Project AI Manager, on behalf of @mekarpeles. Pam is designed to provide status visibility, perform basic project management functions and relevant codebase research, and provide actionable feedback so contributors aren't left waiting.

[Copilot]

Pull request overview

Fixes is_valid_date validation for reading-log check-ins by rejecting out-of-range month and day values, preventing invalid partial dates from being accepted and stored.

Changes:

• Added numeric range guards for month (1–12) and day (1–31) in is_valid_date.
• Added unit tests covering out-of-range and boundary values for month/day.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
openlibrary/plugins/upstream/checkins.py	Adds range validation guards to is_valid_date to reject invalid month/day values.
openlibrary/plugins/upstream/tests/test_checkins.py	Adds new tests to ensure out-of-range and boundary month/day values behave as expected.

[jimchamp]

Thanks @tranmin001!

Please coerce month and day into integers during the range check. These are being passed as type int to the validation function today (verified locally), but some future regression could potentially change this.

[jimchamp]

Lgtm!