Set PYTHONPATH in olbase image to avoid manually specifying it for scripts#12811
Merged
RayBB merged 1 commit intoMay 27, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the olbase Docker image to set a default PYTHONPATH so repository scripts (e.g., scripts/copydocs.py) can be executed inside the container without manually prefixing commands with PYTHONPATH=..
Changes:
- Set
ENV PYTHONPATH=/openlibraryin the base Docker image to make local modules importable by default.
Member
RayBB
approved these changes
May 27, 2026
RayBB
left a comment
Collaborator
There was a problem hiding this comment.
We build and tested locally on the call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got tired of having to specify
PYTHONPATH=.everywhere ; we can bake this into the image and then in theory never specify it again.Technical
Testing
To test it, I added the
ENVline to our oldev file, and then rebuilt it and confirmed copydocs worked without having to set the environment variable.Needs another pass of testing to confirm the site comes up normally with this set though.
Screenshot
Stakeholders
@RayBB