[6.x] Make it possible to disable to disable encryption via 0/false#29985
Merged
Conversation
it is not possible to set an env var to `null`, so its otherwise impossible to disable encryption via an env variable
Contributor
Author
|
now that was fast :) BTW I wonder if there are other places within laravel that should be reviewed for this type of issue. |
GrahamCampbell
changed the title
|
In case someone else comes across this. Setting encryption option to "tcp" means that the mail is sent as plain (with no encryption) ;) Unfortunately, it is not documented, but if you look at the code, it's pretty clear: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it is not possible to set an env var to
null, so its otherwise impossible to disable encryption via an env variablethis will for example make it possible to provide out of the box support for Laravel emailing on platform.sh via their bridge:
https://github.com/platformsh/laravel-bridge/blob/master/platformsh-laravel-env.php#L155