[6.x] migrate --seed should seed the same database#31678
Merged
Conversation
driesvints
changed the title
taylorotwell
added a commit
that referenced
this pull request
Mar 2, 2020
This reverts commit 83f4410.
taylorotwell
added a commit
that referenced
this pull request
Mar 2, 2020
Collaborator
|
Reverted because this is a major breaking change. It may be included in 7.x instead. |
voku
added a commit
to voku/framework
that referenced
this pull request
Mar 2, 2020
* upstream/6.x: (21 commits) Revert "[6.x] migrate --seed should seed the same database (laravel#31678)" (laravel#31685) [6.x] Allow easier customization of the queued mailable job (laravel#31684) [6.x] migrate --seed should seed the same database (laravel#31678) [6.x] Make newPivotQuery public (laravel#31677) [6.x] update changelog Fix flakey memcached tests (laravel#31646) Fixed phpdoc formatting [6.x] Expose Notification Id within Message Data (laravel#31632) [6.x] Add support for Arr::hasAny (laravel#31636) Fix phpdoc [6.x] update changelog [6.x] update changelog Fix styling for phpdoc Create resolve method which loads deferred providers if needed Revert "Call make instead of resolve to load deffered providers" Call make instead of resolve to load deffered providers Add test that failes to load deffered provider of implementation while accessing class through interface Use correct locale when resolving Faker from the container (laravel#31615) clean-up-some-methods ... # Conflicts: # src/Illuminate/Database/DatabaseServiceProvider.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
This pull enables
php artisan migrate --seed --database=xxxto seed the same databaseCurrent behaviour
Currently if you run
php artisan migrate --seed --database=xxx, the specified database will be migrated but seed will be run on default connectionExpected behaviour
php artisan migrate --seed --database=xxxshould migrate and seed the same specified databaseSolution
This pull passes the arguments of the MigrateCommand to the SeedCommand, so if --database is specified it will be used