[10.x] Fixed issue: Added a call to the getValue method#48652
Merged
Conversation
added 5 commits
October 5, 2023 17:55
…QL queries in conditions throw an exception.
Member
|
Please add a simple reproduction example and then mark as ready for review. |
Contributor
Author
|
Since v10.x, all the calls like: This adds support for both of the approaches. |
GrahamCampbell
changed the title
getValue method
timacdonald
pushed a commit
to timacdonald/framework
that referenced
this pull request
Oct 24, 2023
* Fixed issue: Added a call to the getValue method. Without this, raw SQL queries in conditions throw an exception. * Added check to prevent call on types other than Expression * Added new test cases for the modified method * Refactored the variable names * Fixed a StyleCI issue * Update Grammar.php --------- Co-authored-by: Bojan Lozo <bojanlo@maestralsolutions.com> Co-authored-by: Taylor Otwell <taylor@laravel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, raw SQL queries in conditions throw an exception, since they were rewritten in v10.x.