[12.x] add type declarations for Console Events

[browner12]

the added types match the existing constructor docblocks.

not sure what the current sentiment on stricter typing is from the core team, but thought I'd throw this out there. these events are a good place to start as their construction should basically only be internal.

I checked all the calling code, and this may have already uncovered a bug. the CommandStarting claims to accept a string $command parameter, but the calling code possibly sends null. two ways to fix this would be to accept string|null, or to have the calling code null coalesce and empty string (?? '').

if accepted, I'll update all the other events as well.

[shaedrich]

I predict, this will be rejected due to backwards compatibility

[taylorotwell]

@browner12 under what situation does CommandStarting currently receive null?

[browner12]

@taylorotwell I don't know if it actually happens, but in

https://github.com/laravel/framework/blob/11.x/src/Illuminate/Foundation/Console/Kernel.php#L166

the getCommand() can return null, and the getName() can also return null. my guess is it never actually happens, but based on their declared return types they are nullable.

[taylorotwell]

Hmm, ok, I guess we should coalesce in the callers then so the event itself only receives strings.

[browner12]

@taylorotwell code has been updated. I realized the CommandFinished also required a string.

Very weird on symfonys part, how could you have a command event without a command?

[crynobone]

Very weird on symfonys part, how could you have a command event without a command?

php artisan --version

This could be one example.

[browner12]

Very weird on symfonys part, how could you have a command event without a command?

php artisan --version

This could be one example.

if that's not a command, then why is it firing off a command event?

I'm sure they had good reason, just seems odd from the outside looking in.