[12.x] Feature: Array partition#54859
Merged
Merged
Conversation
pandiselvamm
reviewed
Mar 4, 2025
| $failed = []; | ||
|
|
||
| foreach ($array as $key => $item) { | ||
| if ($callback($item, $key)) { |
Contributor
There was a problem hiding this comment.
Suggestion:
foreach ($array as $key => $item) {
($callback($item, $key) ? $passed : $failed)[$key] = $item;
}
Member
|
@liamduckett do you mind sending some docs over for this? |
Contributor
Author
|
Thanks @pandiselvamm. Speedy! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, this PR adds a
partitionmethod to the Array helper.This allows using the existing partition logic, without needing to reach for collections.
I also converted the existing
Collection::partitionto use theArr::partitionmethod, to prevent duplication. Happy to revert this bit if preferable.