[12.x]: Use char(36) for uuid type on MariaDB < 10.7.0#55197
Merged
taylorotwell merged 1 commit intoApr 3, 2025
Conversation
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
Contributor
Author
|
@taylorotwell I fixed the tests and created a second PR. Tests run locally, however on GitHub one container in the matrix tests could not start up. Is there a way to restart this run? Or how to proceed? |
Contributor
|
@boedah I don't think they review PRs marked as draft, you can mark it as ready and someone will restart the test workers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the new Laravel
mariadbdriver results in an errorGeneral error: 4161 Unknown data type: 'uuid'on MariaDB < 10.6.x (which is a still supported LTS version till July 2026: https://mariadb.com/kb/en/changes-and-improvements-in-mariadb-10-6/)uuidcolumn types were added in 10.7.0: https://mariadb.com/kb/en/mariadb-1070-release-notes/This PR adds a version check to use
char(36)on MariaDB < 10.7.0