[12.x] Update Date Facade Docblocks#55235
Merged
Merged
Conversation
|
auto reverted 1d65895 |
Contributor
|
Looks like we might need to open a PR to laravel/facade-documenter in order to fix this issue. The facade documenter is being run in the github action here. |
Contributor
|
Nevermind, we need to change the docblocks on |
Contributor
Author
|
Oh, I see. I missed that file. Thanks for catching that. |
Contributor
|
Hopefully #55243 will fix this haha |
Contributor
|
Yay! After the merge, the github action created 5849cbb and fixed it! |
Contributor
Author
|
Awesome! Thank you again for catching that. I missed that file earlier and focused on the facade itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the accepted docblock parameter from
DateTimeInterfaceandDateTimeZoneto\DateTimeInterfaceand\DateTimeZone. This prevents IDEs and phpstan from complaining on stuff like below:Error: Parameter #1 $date of static method Illuminate\Support\Facades\Date::instance() expects Illuminate\Support\Facades\DateTimeInterface, DateTime given.