[12.x] Fix pivot model events not working when using the withPivotValue#55280
Merged
taylorotwell merged 2 commits intoApr 11, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #55026.
updateExistingPivot, there is no extra cost in terms of performance; it's already sending a database query for fetching data when using theupdateExistingPivotmethod for custom classes. (InteractsWithPivotTable.php#L242)detach, a query likeupdateExistingPivotwill be run before deleting, only if the user uses a custom pivot class andwithPivotValue(orwherePivot), otherwise, it's working exactly as it was working before.updateExistingPivotused the collectionwheremethod instead of query builderwheremethod, so I added a new method to get currently attached pivot models with related keys filter, so thewheremethod will run by query builder instead of collection for better performance and not fetching data that is not needed for update/delete pivots.