Use value() helper in 'when' method

[mohammadrasoulasghari]

When using the when method, it first checked if the given value was a Closure and then executed it.
This is essentially the same logic as value() helper, which was being re-implemented here.

framework/src/Illuminate/Collections/helpers.php

Lines 234 to 237 in 17786ca

	function value($value, ...$args)
	{
	return $value instanceof Closure ? $value(...$args) : $value;
	}

This PR replaces that duplicated logic with a direct call to value().

similar in #54650

[rodrigopedra]

@mohammadrasoulasghari the difference is that one can use the illuminate/conditionable component in a project outside of Laravel without requiring the full illuminate/support component, or the illuminate/collections component, where the helper() value is defined.

In that case, any project requiring the illuminate/conditionable component, but none of the other components mentioned above, will break, as the value() helper won't be available.

cc @taylorotwell

[rodrigopedra]

List of packages that are dependent on illuminate/conditionable:

https://packagist.org/packages/illuminate/conditionable/dependents?order_by=downloads

[mohammadrasoulasghari]

@rodrigopedra Thank you for carefully reviewing the changes and accuracy.

As shown in the link you provided, illuminate/collections is already listed as a dependency, correct?

And the value() helper is defined within that package at this path:
https://github.com/illuminate/collections/blob/33af474390fabf0b17b963f84e78952489147d86/helpers.php#L234

So just to clarify — if illuminate/collections is indeed a required dependency of the package, and value() is part of that package, where exactly is the issue?

[rodrigopedra]

@mohammadrasoulasghari, it is actually the opposite.

The link lists the packages which are dependent upon illuminate/conditionable. That means illuminate/collections depends on illuminate/conditionable, not the opposite.

You can check illuminate/conditionable doesn't depend on illuminate/collections on its composer.json file:

framework/src/Illuminate/Conditionable/composer.json

Lines 16 to 18 in 3faeb07

	"require": {
	"php": "^8.2"
	},

[rodrigopedra]

Also, the link shows only published packages which depend on illuminate/conditionable.

There also can be other projects, not published as packages, which depend on illuminate/conditionable.

[mohammadrasoulasghari]

Also, the link shows only published packages which depend on illuminate/conditionable.

There also can be other projects, not published as packages, which depend on illuminate/conditionable.

Ah yes, you're right — I was wrong about this.
I'll create a PR to revert these changes.