Skip to content

[12.x] Add Enum support for assertJsonPath in AssertableJsonString.php#55516

Merged
taylorotwell merged 4 commits into
laravel:12.xfrom
azim-kordpour:12.x
Apr 23, 2025
Merged

[12.x] Add Enum support for assertJsonPath in AssertableJsonString.php#55516
taylorotwell merged 4 commits into
laravel:12.xfrom
azim-kordpour:12.x

Conversation

@azim-kordpour

@azim-kordpour azim-kordpour commented Apr 22, 2025

Copy link
Copy Markdown
Contributor

Hi,
To improve code readability and prevent typos, I added Enum support for assertJsonPath in this PR.

// Before
$this->postJson('book')
     ->assertJsonPath('data.status', BookingStatus::Booked->value);
// After
$this->postJson('book')
     ->assertJsonPath('data.status', BookingStatus::Booked);

shaedrich
shaedrich reviewed Apr 23, 2025
View reviewed changes
Comment thread src/Illuminate/Testing/AssertableJsonString.php Outdated
azim-kordpour and others added 2 commits April 23, 2025 11:17
@azim-kordpour @shaedrich
Use enum_value in assertPath
530c6fa 
Co-authored-by: Sebastian Hädrich <11225821+shaedrich@users.noreply.github.com>
@azim-kordpour
Import enum_value in AssertableJsonString
fa8c77b
@azim-kordpour

azim-kordpour commented Apr 23, 2025

Copy link
Copy Markdown
Contributor Author

@shaedrich
Thank you for the suggestion.

@shaedrich

shaedrich commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

@azim-kordpour You're welcome.

@taylorotwell taylorotwell merged commit 573684f into laravel:12.x Apr 23, 2025
@AhmedAlaa4611 AhmedAlaa4611 mentioned this pull request May 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@shaedrich shaedrich shaedrich left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@azim-kordpour @shaedrich @taylorotwell