Skip to content

[11.x] Fix validation to not throw incompatible validation exception#55963

Merged
taylorotwell merged 2 commits into
11.xfrom
11/issue-55944
Jun 10, 2025
Merged

[11.x] Fix validation to not throw incompatible validation exception#55963
taylorotwell merged 2 commits into
11.xfrom
11/issue-55944

Conversation

@crynobone

@crynobone crynobone commented Jun 9, 2025

Copy link
Copy Markdown
Member

fixes #55944

@crynobone crynobone requested a review from timacdonald June 9, 2025 08:45
@crynobone
[11.x] Fix validation to not throw incompatible validation exception
66975f6 
fixes #55944

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@crynobone crynobone marked this pull request as ready for review June 9, 2025 12:38
@taylorotwell

taylorotwell commented Jun 9, 2025

Copy link
Copy Markdown
Member

rescue might not be defined if validation is being used as a component outside of the framework.

@taylorotwell taylorotwell marked this pull request as draft June 9, 2025 14:06
@crynobone
wip
cc90fb1 
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@crynobone crynobone marked this pull request as ready for review June 9, 2025 23:15
@crynobone

crynobone commented Jun 9, 2025

Copy link
Copy Markdown
Member Author

fixed, change to use basic try ... catch

@taylorotwell taylorotwell merged commit 49dd2f5 into 11.x Jun 10, 2025
59 checks passed
@taylorotwell taylorotwell deleted the 11/issue-55944 branch June 10, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timacdonald timacdonald Awaiting requested review from timacdonald

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@crynobone @taylorotwell