[12.x] Add assertRedirectBackWithErrors to TestResponse#55987
Merged
taylorotwell merged 5 commits intoJun 12, 2025
Conversation
Member
|
It raises more permutations in my mind... should there also be |
Contributor
Author
That's a good point; I hadn't considered that, but I agree it makes sense for completeness and symmetry. I'm happy to add Should I make it in the same PR or in another PR? |
Member
|
I got it! Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new
assertRedirectBackWithErrors()method to streamline testing redirect-back responses that include validation errors.Currently, developers need to write:
With this addition, the test can be simplified to:
Internally, this method simply calls
assertRedirectBack()andassertSessionHasErrors(), so it's a convenience wrapper that improves test readability and reduces duplication.About tests
I didn't include a separate test for this method since it delegates entirely to two existing, well-tested assertions.