[12.x] Refine type hinting for condition rules

[michaelnabil230]

Refine type hinting for condition rules

[patrickomeara]

This is a breaking change for me. Originally Rule::requiredIf() would work with truthy values, not strict boolean/callback.

In my case I was applying the rule if a route param was present. Sure, I can cast it to boolean pretty simply but a breaking change in a patch version is not ideal, in a PR focusing on type hints nonetheless.

Rule::requiredIf($this->route('label'))

I agree that the original is_string() check was confusing, I can't see why string values were not allowed when we could pass other truthy values: ints, objects etc.

A better approach might be to accept any value, string or not, this too would be a breaking change, however only for those expecting an InvalidArgumentException to be thrown when a string is passed in, a pretty unlikely scenario.

If the strictness is to stay, there is no reason why native types can't be used.

    public function __construct(Closure|bool|null $condition)
    {
        $this->condition = $condition;
    }

My vote is to drop the strictness and allow any truthy/falsy value. Happy to PR something to fix this breaking change pending your opinion @taylorotwell