Add softDeleteResources method in Router#56440
Merged
taylorotwell merged 2 commits intoJul 27, 2025
Merged
Conversation
Contributor
|
This seems like such an odd way to group things. You've now created a behavior connection between these 2 resources that exists purely by happenstance, not by intent. |
Contributor
|
I realize I'm late to the party, but the naming seems very odd to me to be honest. "SoftDeletable" for me means the "can be soft deleted", not that they are included. I don't think I like this change... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
softDeletableResourcesmethod for the Router class to register multiple resource controllers that all use the withTrashed method.Example
Output:
Same as
Route::resources(), but includes soft deleted models in the query for show, update, destroy and editBenefit:
It would save from having to manually do the following for each resource controller where it uses the withTrashed scope:
Edited to reflect the updated method name.